-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctsm5.3.022: Update FATES namelist and build options to avoid Meier2022
#2934
Conversation
…ce to allow memory allocation handling
If fates is on, default to ZengWang2007, otherwise use Meier2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @glemieux and getting this in quickly. We'll talk Thursday on where this should go in upcoming tags.
I ask for a couple changes that are easy.
this avoids the need to set a `.true.` condition for z0param_method in the defaults
…h fates" This reverts commit 43407e1.
Meier2022
Meier2022
Regression testing on |
Perfectly fine @glemieux and up to you. Since this is a tag on master there is no need to make it b4b. So do what you need to do. |
…fates-meier-bldcheck
Standardize time metadata (release tag for ctsm5.3) Last of the 3 "history" tags that ended up numbered as follows: ctsm5.3.018 time now middle of time_bounds ctsm5.3.019 eliminate 0th time step ctsm5.3.021 standardize time metadata As the release tag for ctsm5.3, this also includes the file WhatsNewInCTSM5.3.md. PRs that document the changes ESCOMP#2052 ESCOMP/MOSART#66 ESCOMP/RTM#35
…fates-meier-bldcheck
Regression testing |
Regression testing on Expected fates tests are b4b with the exception of tests that use
All expected clm tests are b4b except for
Looking at the med.log I don't see anything in particular jumping out at me, but I don't review this log often. I haven't been able to check Results : |
#1733 discusses this test SMS_D.f10_f10_mg37.I2000Clm60BgcCrop.derecho_nvhpc.clm-crop |
Per discussion with @rgknox at the standup this morning, it is likely that NGEET/fates#1306 is the cause of the Results: As such, testing on |
This reverts commit 0ac98fb.
This is an older, low-priority issue. The fates team decided to remove this to avoid having this as a recurring expected failure.
Per discussion with @rgknox, I've removed Rerunning tests on izumi as it seems some tests were mangled during last Friday's issues. |
Rerunning |
Resubmitting failed Three tests did not manage to generate baselines due to lack of space:
Aside from that, this PR is ready to merge. Results: |
Description of changes
Avoid running
fates
withz0param_method=Meier2022
in light of #2932.Specific notes
This also merges #2936 and #2898
Contributors other than yourself, if any: @rgknox
CTSM Issues Fixed (include github issue #):
Does the first step in #2932
Are answers expected to change (and if so in what way)? Yes, for fates compsets with
Clm60
Any User Interface Changes (namelist or namelist defaults changes)? Yes, changes default for roughness for FATES and disallows one option when FATES is used
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: will do regular and fates tests suites