Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctsm5.3.022: Update FATES namelist and build options to avoid Meier2022 #2934

Merged
merged 26 commits into from
Feb 6, 2025

Conversation

glemieux
Copy link
Collaborator

@glemieux glemieux commented Jan 14, 2025

Description of changes

Avoid running fates with z0param_method=Meier2022 in light of #2932.

Specific notes

This also merges #2936 and #2898

Contributors other than yourself, if any: @rgknox

CTSM Issues Fixed (include github issue #):
Does the first step in #2932

Are answers expected to change (and if so in what way)? Yes, for fates compsets with Clm60

Any User Interface Changes (namelist or namelist defaults changes)? Yes, changes default for roughness for FATES and disallows one option when FATES is used

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: will do regular and fates tests suites

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations FATES A change needed for FATES that doesn't require a FATES API update. science Enhancement to or bug impacting science non-bfb Changes answers (incl. adding tests) size: small test: aux_clm Pass aux_clm suite before merging test: fates Pass fates test suite before merging labels Jan 14, 2025
@ekluzek ekluzek added this to the cesm3_0_beta06 milestone Jan 14, 2025
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @glemieux and getting this in quickly. We'll talk Thursday on where this should go in upcoming tags.

I ask for a couple changes that are easy.

bld/CLMBuildNamelist.pm Outdated Show resolved Hide resolved
@ekluzek ekluzek changed the title Update FATES namelist and build options to avoid Meier2022 ctsm5.3.022: Update FATES namelist and build options to avoid Meier2022 Jan 16, 2025
@glemieux
Copy link
Collaborator Author

Regression testing on derecho is underway.

@ekluzek
Copy link
Collaborator

ekluzek commented Jan 27, 2025

Perfectly fine @glemieux and up to you. Since this is a tag on master there is no need to make it b4b. So do what you need to do.

Standardize time metadata (release tag for ctsm5.3)

 Last of the 3 "history" tags that ended up numbered as follows:
 ctsm5.3.018 time now middle of time_bounds
 ctsm5.3.019 eliminate 0th time step
 ctsm5.3.021 standardize time metadata

 As the release tag for ctsm5.3, this also includes the file WhatsNewInCTSM5.3.md.

 PRs that document the changes
 ESCOMP#2052
 ESCOMP/MOSART#66
 ESCOMP/RTM#35
@glemieux glemieux mentioned this pull request Jan 31, 2025
4 tasks
@glemieux
Copy link
Collaborator Author

Regression testing aux_clm on izumi and derecho is underway.

@glemieux
Copy link
Collaborator Author

glemieux commented Feb 3, 2025

Regression testing on derecho is complete. I discovered NGEET/fates#1324 during testing and have updated the expected failure test list accordingly. Also I ran into #2930 again, so I reran the suite omitting the --testid-base option for the system tests.

Expected fates tests are b4b with the exception of tests that use Clm60Fates based compsets, which is as expected due to using ZengWang2007 instead of Meier2022 per this PR. An additional three tests are showing DIFFs for the FATES_GDD variable only. @rgknox did you see this during testing of NGEET/fates#1306?

FAIL ERS_D_Ld20.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesColdTwoStream BASELINE ctsm5.3.021: DIFF
FAIL ERS_Ld30.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesColdFixedBiogeo BASELINE ctsm5.3.021: DIFF
FAIL SMS_D_Lm6_P256x1.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesCold BASELINE ctsm5.3.021: DIFF

All expected clm tests are b4b except for SMS_D.f10_f10_mg37.I2000Clm60BgcCrop.derecho_nvhpc.clm-crop. This is failing during RUN with the following in the Teststatus:

153  ---------------------------------------------------
154 2025-02-03 00:19:44: ERROR: Model did not complete - see /glade/u/home/glemieux/scratch/ctsm-tests/tests_0202-192217de/SMS_D.f10_f10_mg37.I2000Clm60BgcCrop.derecho_nvhpc.clm-crop.GC.0202-192217de_nvh/    run/med.log.7645521.desched1.250203-001918
155 
156  ---------------------------------------------------

Looking at the med.log I don't see anything in particular jumping out at me, but I don't review this log often.

I haven't been able to check izumi results due to what I'm assuming are continued issues seen from this past week.

Results : /glade/u/home/glemieux/scratch/ctsm-tests/tests_0202-192217de

@slevis-lmwg
Copy link
Contributor

#1733 discusses this test SMS_D.f10_f10_mg37.I2000Clm60BgcCrop.derecho_nvhpc.clm-crop

@glemieux
Copy link
Collaborator Author

glemieux commented Feb 3, 2025

Per discussion with @rgknox at the standup this morning, it is likely that NGEET/fates#1306 is the cause of the FATES_GDD differences seen above. To confirm, I ran one of the above tests using the fates tag associated with that PR ,fates-sci.1.80.9_api.37.0.0-ctsm5.3.018, and compared it against the previous baseline. The results are consistent and can be found below.

Results: /glade/u/home/glemieux/ctsm/tests_0203-114755de

As such, testing on derecho is complete. Just waiting on izumi to come back up to check tests there.

This is an older, low-priority issue.  The fates team decided to remove this to avoid
having this as a recurring expected failure.
@glemieux
Copy link
Collaborator Author

glemieux commented Feb 4, 2025

Per discussion with @rgknox, I've removed FATES_C13_DISC_SZPF from AllVars as this is a known low priority issue (see NGEET/fates#700). I've rerun the AllVars test and regenerated that specific baseline.

Rerunning tests on izumi as it seems some tests were mangled during last Friday's issues.

@glemieux
Copy link
Collaborator Author

glemieux commented Feb 4, 2025

Rerunning aux_clm izumi tests again as a number of them failed due to input data still not being available yesterday evening.

@glemieux
Copy link
Collaborator Author

glemieux commented Feb 5, 2025

Resubmitting failed aux_clm cases on izumi via --rerun-existing-failures seem to have mostly worked. Nearly all expected tests are B4B. The only DIFFs are for fates testmods and are expected due either to the z0param_method update or due to a fates update to the temperature average (i.e. the FATES_GDD diffs mentioned above).

Three tests did not manage to generate baselines due to lack of space:

(ctsm_pylib) [glemieux@izumi tests_0204-101554iz]$ ./cs.status -f | grep -i generate
    FAIL ERS_Ld600_Mmpi-serial.1x1_smallvilleIA.I1850Clm50BgcCrop.izumi_gnu.clm-cropMonthlyNoinitial GENERATE exception
    FAIL SMS_Ld5_Mmpi-serial.1x1_brazil.IHistClm60Bgc.izumi_gnu.clm-mimics GENERATE exception
    FAIL SMS_Ln9.f10_f10_mg37.I1850Clm45Bgc.izumi_gnu.clm-clm45cam4LndTuningModeZDustSoilErod GENERATE exception

Aside from that, this PR is ready to merge.

Results: /home/glemieux/ctsm/tests_0204-101554iz

@samsrabin samsrabin requested a review from ekluzek February 6, 2025 18:16
@samsrabin samsrabin merged commit 930b3eb into ESCOMP:master Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability FATES A change needed for FATES that doesn't require a FATES API update. non-bfb Changes answers (incl. adding tests) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science size: small test: aux_clm Pass aux_clm suite before merging test: fates Pass fates test suite before merging
Projects
Status: Done (non release/external)
Development

Successfully merging this pull request may close these issues.

'Meier 2022' z0 parameterization causes errors with FATES (especially in SP mode.)
5 participants